-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update backfill job, and setup a cronjob in prod #1077
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
severo
changed the title
Update backfill job
Update backfill job, and setup a cronjob in prod
Apr 21, 2023
ArgoCD Diff for commit
|
Legend | Status |
---|---|
✅ | The app is synced in ArgoCD, and diffs you see are solely from this PR. |
The app is out-of-sync in ArgoCD, and the diffs you see include those changes plus any from this PR. | |
🛑 | There was an error generating the ArgoCD diffs due to changes in this PR. |
The documentation is not available anymore as the PR was closed or merged. |
severo
force-pushed
the
update-backfill-job
branch
from
April 21, 2023 14:12
7d01713
to
1ce4735
Compare
AndreaFrancis
approved these changes
Apr 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
backfill/upgrade look better now, thanks!
severo
force-pushed
the
update-backfill-job
branch
from
April 21, 2023 15:14
1ce4735
to
768513d
Compare
Because a job has not the sufficient information to know which cache entries whould be deleted or not. Let's use backfill for that (in a next PR. It's not an issue to have dangling cache entries meanwhile)
and delete unused code
severo
force-pushed
the
create-children-jobs-if-error
branch
from
April 26, 2023 10:03
1b49260
to
af2c3fd
Compare
Also: remove the "upgrade" action, since it's handled by backfill. Also: remove test for backfill action, because it's not clear how it would work (maybe -> e2e test)
Co-authored-by: Andrea Francis Soria Jimenez <andrea@huggingface.co>
severo
force-pushed
the
update-backfill-job
branch
from
April 26, 2023 10:08
bcb4240
to
a705381
Compare
AndreaFrancis
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.