Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pdf2image as preinstalled package #688

Closed
mariosasko opened this issue Jan 20, 2023 · 2 comments · Fixed by #691
Closed

Add pdf2image as preinstalled package #688

mariosasko opened this issue Jan 20, 2023 · 2 comments · Fixed by #691

Comments

@mariosasko
Copy link
Contributor

Needed for: https://huggingface.co/datasets/jordyvl/unit-test_PDFfolder (the installation instructions for pdf2image can be found there)
severo added a commit that referenced this issue Jan 20, 2023
@severo
feat: 🎸 add support for pdf2image
47d3297 
✅ Closes: #688
@severo severo mentioned this issue Jan 20, 2023
Merged
severo added a commit that referenced this issue Jan 23, 2023
@severo
feat: 🎸 add support for pdf2image (#691)
fd39deb 
* feat: 🎸 add support for pdf2image

✅ Closes: #688

* feat: 🎸 update image
@severo
Copy link
Collaborator

severo commented Jan 23, 2023

Partly fixed with #691: the pdf2image dependency has been added, and we get a result: https://huggingface.co/datasets/jordyvl/unit-test_PDFfolder

But it shows a new issue (unrelated): we should be showing a gallery of images, and instead, we have a JSON. I'm working on it.

Capture d’écran 2023-01-23 à 11 31 49

@severo severo reopened this Jan 23, 2023
@severo severo closed this as completed Jan 23, 2023
@severo
Copy link
Collaborator

severo commented Jan 23, 2023

Fixed!

https://huggingface.co/datasets/jordyvl/unit-test_PDFfolder

Capture d’écran 2023-01-23 à 22 28 11

@severo severo mentioned this issue Jul 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: 🎸 add support for pdf2image huggingface/dataset-viewer
2 participants
@severo @mariosasko