Skip to content

Commit

Permalink
fix: 🐛 set the modules cache inside /tmp (#418)
Browse files Browse the repository at this point in the history
by default, it was created in `/.cache` which cannot be written.
  • Loading branch information
severo authored Jun 23, 2022
1 parent ec95bbc commit f2f5706
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
value: {{ .Values.datasetsWorker.datasetsRevision | quote }}
- name: HF_DATASETS_CACHE
value: "{{ .Values.datasetsWorker.cacheDirectory }}/datasets"
# note: HF_MODULES_CACHE is not set to a shared directory
# we let "datasets" find a directory by itself: we want a different cache for the modules for each worker
# and the size should remain so small that we don't need to worry about putting it on an external storage
- name: HF_MODULES_CACHE
value: "/tmp/modules-cache"
# the size should remain so small that we don't need to worry about putting it on an external storage
# see https://github.com/huggingface/datasets-server/issues/248
- name: HF_TOKEN
# see https://kubernetes.io/docs/concepts/configuration/secret/#creating-a-secret
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,9 @@
- name: HF_DATASETS_CACHE
value: "{{ .Values.splitsWorker.cacheDirectory }}/datasets"
# note: HF_MODULES_CACHE is not set to a shared directory
# we let "datasets" find a directory by itself: we want a different cache for the modules for each worker
# and the size should remain so small that we don't need to worry about putting it on an external storage
- name: HF_MODULES_CACHE
value: "/tmp/modules-cache"
# the size should remain so small that we don't need to worry about putting it on an external storage
# see https://github.com/huggingface/datasets-server/issues/248
- name: HF_TOKEN
# see https://kubernetes.io/docs/concepts/configuration/secret/#creating-a-secret
Expand Down

0 comments on commit f2f5706

Please sign in to comment.