Skip to content

Commit

Permalink
404 improve error messages (#444)
Browse files Browse the repository at this point in the history
* feat: 🎸 add as_response() method to exceptions

the 400 errors have more details

* feat: 🎸 remove dependency to libutils

* feat: 🎸 remove dependency to libutils

* feat: 🎸 update libs

now: libutils, libcache and libqueue are independent

* feat: 🎸 make some fields of 400 error response optional

* fix: 🐛 catch server errors and return a Status500Error

✅ Closes: #436

* feat: 🎸 depend on libutils again

duplicating the definitions generated incompatibilites. We depend on
libutils until we remove /splits and /rows

* feat: 🎸 depend again libcache on libutils

* refactor: 💡 use the new ethods

* feat: 🎸 improve the error messages

✅ Closes: #404

* fix: 🐛 manage when num_bytes or num_examples don't exist

* feat: 🎸 update docker images
  • Loading branch information
severo authored Jul 21, 2022
1 parent 401cfcc commit 01521ec
Show file tree
Hide file tree
Showing 38 changed files with 315 additions and 1,448 deletions.
12 changes: 6 additions & 6 deletions infra/charts/datasets-server/docker-images.yaml
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
{
"dockerImage": {
"admin": "707930574880.dkr.ecr.us-east-1.amazonaws.com/hub-datasets-server-admin:sha-9e66a36",
"api": "707930574880.dkr.ecr.us-east-1.amazonaws.com/hub-datasets-server-api:sha-c05b21f",
"admin": "707930574880.dkr.ecr.us-east-1.amazonaws.com/hub-datasets-server-admin:sha-b9b0a95",
"api": "707930574880.dkr.ecr.us-east-1.amazonaws.com/hub-datasets-server-api:sha-b9b0a95",
"reverseProxy": "docker.io/nginx:1.20",
"worker": {
"datasets": "707930574880.dkr.ecr.us-east-1.amazonaws.com/hub-datasets-server-worker:sha-2043e54",
"firstRows": "707930574880.dkr.ecr.us-east-1.amazonaws.com/hub-datasets-server-worker:sha-2043e54",
"splits": "707930574880.dkr.ecr.us-east-1.amazonaws.com/hub-datasets-server-worker:sha-2043e54",
"splitsNext": "707930574880.dkr.ecr.us-east-1.amazonaws.com/hub-datasets-server-worker:sha-2043e54"
"datasets": "707930574880.dkr.ecr.us-east-1.amazonaws.com/hub-datasets-server-worker:sha-52a3066",
"firstRows": "707930574880.dkr.ecr.us-east-1.amazonaws.com/hub-datasets-server-worker:sha-52a3066",
"splits": "707930574880.dkr.ecr.us-east-1.amazonaws.com/hub-datasets-server-worker:sha-52a3066",
"splitsNext": "707930574880.dkr.ecr.us-east-1.amazonaws.com/hub-datasets-server-worker:sha-52a3066"
}
}
}
Binary file not shown.
Binary file added libs/libcache/dist/libcache-0.1.11.tar.gz
Binary file not shown.
Binary file not shown.
Binary file added libs/libcache/dist/libcache-0.1.12.tar.gz
Binary file not shown.
Loading

0 comments on commit 01521ec

Please sign in to comment.