Fix message update migration not applying #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gary149
approved these changes
May 24, 2024
|
feel free to merge directly @mishig25 |
mishig25
reviewed
May 24, 2024
| @@ -150,7 +150,7 @@ const updateMessageUpdates: Migration = { | |||
| _id: new ObjectId("5f9f4f4f4f4f4f4f4f4f4f4f"), | |||
There was a problem hiding this comment.
don't we have to change the id?
Otherwise, since migration with this id was already recorded as done, it will not run. No?
There was a problem hiding this comment.
or should we create new migration src/lib/migrations/routines/06-xyz.ts ?
There was a problem hiding this comment.
I think the idea was to delete the existing migration flag in the prod db so it would run again. But I think migrations should be append only no? Not sure how we could squash them together effectively
There was a problem hiding this comment.
Yeah good call, updated the id so it will run again. The first run didn't work so this should be safe
ice91
pushed a commit
to ice91/chat-ui
that referenced
this pull request
Oct 30, 2024
* fix: message update migration not applying * feat: change message updates migration id to trigger re-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the message update migrations needed as part of #996 not applying to the tools objects.