Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ds-z3-init and prepending ds env variables with ACCELERATE_ #928

Merged
merged 3 commits into from
Dec 16, 2022
Merged

ds-z3-init and prepending ds env variables with ACCELERATE_ #928

merged 3 commits into from
Dec 16, 2022

Conversation

pacman100
Copy link
Contributor

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Dec 16, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@pacman100 pacman100 requested review from sgugger and stas00 December 16, 2022 17:53
@pacman100 pacman100 marked this pull request as ready for review December 16, 2022 17:55
muellerzr
muellerzr approved these changes Dec 16, 2022
View reviewed changes
Copy link
Collaborator

@muellerzr muellerzr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M, I'll have the slow runners test this as well before we merge :) (and review by @stas00 )

stas00
stas00 suggested changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@stas00 stas00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the improvements, @pacman100!

I left a few small suggestions.

src/accelerate/utils/dataclasses.py Show resolved Hide resolved
src/accelerate/utils/dataclasses.py Show resolved Hide resolved
src/accelerate/commands/launch.py Show resolved Hide resolved
src/accelerate/commands/launch.py Show resolved Hide resolved
@pacman100 pacman100 merged commit ca6505a into huggingface:main Dec 16, 2022
@pacman100 pacman100 deleted the smangrul/ds-z3-init-and-other-minor-fixes branch December 20, 2022 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muellerzr muellerzr muellerzr approved these changes

@stas00 stas00 stas00 approved these changes

@sgugger sgugger Awaiting requested review from sgugger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pacman100 @HuggingFaceDocBuilderDev @muellerzr @stas00