Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand sanity checks #905

Merged
merged 2 commits into from
Dec 6, 2022
Merged

Expand sanity checks #905

merged 2 commits into from
Dec 6, 2022

Conversation

muellerzr
Copy link
Collaborator

Closes #903 by adding more sanity checks to launch_command including more compute type options with the latest ones and checking if we are doing multi_gpu num processes > 2

@muellerzr muellerzr added the enhancement New feature or request label Dec 6, 2022
@muellerzr muellerzr requested a review from sgugger December 6, 2022 20:25
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Dec 6, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger approved these changes Dec 6, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@muellerzr muellerzr merged commit 2359af1 into main Dec 6, 2022
@muellerzr muellerzr deleted the cli-guarding branch December 6, 2022 20:46
@thethomasboyer thethomasboyer mentioned this pull request Sep 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI should guard against bad input parameters
3 participants
@muellerzr @HuggingFaceDocBuilderDev @sgugger