Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowing encoded configuration for DeepSpeed #895

Merged
merged 3 commits into from
Jan 11, 2023
Merged

Allowing encoded configuration for DeepSpeed #895

merged 3 commits into from
Jan 11, 2023

Conversation

cli99
Copy link
Contributor

@cli99 cli99 commented Nov 29, 2022

DeepSpeed now allows deespeed configuration passed in as a base64 encoded string. This PR updates the check in accelerate to accommodate that change.

@cli99 cli99 changed the title Allow encoded ds config Allowing encoded configuration for DeepSpeed Nov 29, 2022
@sgugger sgugger requested a review from pacman100 November 29, 2022 19:59
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 29, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

pacman100
pacman100 reviewed Nov 30, 2022
View reviewed changes
Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this 🤗! LGTM. Please resolve the quality checks and then we are good to go.

@pacman100
Copy link
Contributor

Please do pip install -e .[quality] and make style; make quality; from the root of the repo to pass the quality failure

@Cyberes Cyberes mentioned this pull request Dec 3, 2022
Merged
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot closed this Jan 8, 2023
@muellerzr muellerzr reopened this Jan 8, 2023
pacman100
pacman100 approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thank you for the changes. LGTM! 🤗

sgugger
sgugger approved these changes Jan 11, 2023
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@sgugger sgugger merged commit 741d233 into huggingface:main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacman100 pacman100 pacman100 approved these changes

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cli99 @HuggingFaceDocBuilderDev @pacman100 @sgugger @muellerzr