Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deepspeed example should use gather_for_metrics #821

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Deepspeed example should use gather_for_metrics #821

merged 2 commits into from
Nov 10, 2022

Conversation

HammadB
Copy link
Contributor

@HammadB HammadB commented Nov 6, 2022

I believe this example should be using gather_for_metrics here instead of gather to work correctly on distributed setups.

@HammadB
Deepspeed example should use gather_for_metrics
89597d0 
I believe this example should be using gather_for_metrics here instead of gather.
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

pacman100
pacman100 reviewed Nov 7, 2022
View reviewed changes
Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, Thank you for the update! 🤗
Left a comment

examples/by_feature/deepspeed_with_config_support.py Outdated Show resolved Hide resolved
@pacman100 pacman100 self-requested a review November 10, 2022 06:37
pacman100
pacman100 approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the DeepSpeed example. LGTM! 🤗

sgugger
sgugger approved these changes Nov 10, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@sgugger sgugger merged commit ccdc225 into huggingface:main Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

@pacman100 pacman100 pacman100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HammadB @HuggingFaceDocBuilderDev @pacman100 @sgugger