Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deal with optimizer.differentiable in PyTorch 1.13.0 #803

Merged
merged 3 commits into from
Oct 31, 2022
Merged

Deal with optimizer.differentiable in PyTorch 1.13.0 #803

merged 3 commits into from
Oct 31, 2022

Conversation

comaniac
Copy link
Contributor

Details are in #801.

cc @sgugger

@comaniac
Copy link
Contributor Author

closing #801

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 31, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger reviewed Oct 31, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

src/accelerate/accelerator.py Outdated Show resolved Hide resolved
sgugger
sgugger approved these changes Oct 31, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nit :-)

src/accelerate/accelerator.py Outdated Show resolved Hide resolved
@comaniac @sgugger
Update src/accelerate/accelerator.py
caccdb0 
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
@pacman100
Copy link
Contributor

Thank you for the quick fix! 🤗

@sgugger sgugger merged commit c4c444a into huggingface:main Oct 31, 2022
@comaniac comaniac deleted the patch-1 branch October 31, 2022 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@comaniac @HuggingFaceDocBuilderDev @pacman100 @sgugger