Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating docs to use fork of megatron-lm and minor example/docs fix #766

Merged

Conversation

pacman100
Copy link
Contributor

What does this PR do?

  1. Maintaining 🤗 fork of Megatron-LM: https://github.com/huggingface/Megatron-LM. Updating docs to directly install from it instead of the current long process.
  2. wandb was resulting in the below error when doing accelerator.end_training() with Megatron-LM. On commenting those 2 lines, everything works properly. For Megatron-LM, the main process is the last rank as that will have loss from the last pipeline stage, this might be behaving weirdly with closing the wandb connection using run.finish. Commenting it for now.
envs/ml/lib/python3.10/site-packages/wandb/sdk/service/streams.py", line 187, in get_stream
    stream = self._streams[stream_id]
KeyError: '26ll3a5t'
  1. Minor megatron-lm docs fixes to make output logs in sync with the config and args

@pacman100 pacman100 requested a review from sgugger October 17, 2022 13:54
@pacman100 pacman100 changed the title updating docs to use fork of megatorn-lm and minor example/docs fix updating docs to use fork of megatron-lm and minor example/docs fix Oct 17, 2022
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 17, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes! Do you plan to update the fork regularly?

@pacman100
Copy link
Contributor Author

Hello @sgugger, wrt maintaining fork, sure, I can do that. This would help in making sure the functionality works with accelerate and we can extend it for more features (main repo is barely active).

@pacman100 pacman100 merged commit a635111 into huggingface:main Oct 17, 2022
@pacman100 pacman100 deleted the smangrul/update-megatron-lm-docs branch October 18, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants