updating docs to use fork of megatron-lm and minor example/docs fix #766
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
accelerator.end_training()
with Megatron-LM. On commenting those 2 lines, everything works properly. For Megatron-LM, the main process is the last rank as that will have loss from the last pipeline stage, this might be behaving weirdly with closing the wandb connection usingrun.finish
. Commenting it for now.