Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor #758

Merged
merged 1 commit into from
Oct 15, 2022
Merged

refactor #758

merged 1 commit into from
Oct 15, 2022

Conversation

pacman100
Copy link
Contributor

What does this PR do?

  1. Refactoring as per comment on Megatron-LM integration #667 (comment)

@pacman100 pacman100 mentioned this pull request Oct 14, 2022
4 tasks
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 14, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great refactoring!

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot for remembering!

@pacman100 pacman100 merged commit 148f6dc into huggingface:main Oct 15, 2022
@pacman100 pacman100 deleted the smangrul/refactor branch October 15, 2022 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants