-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ds launcher] un-hijack PYTHONPATH #741
Conversation
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR! LGTM but let's wait to see what @pacman100 thinks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Stas for the fix 🤗! As you mentioned, it shouldn't be a path to a file. Instead, it should be the pwd
of the launched-from-dir.
Oops, Thanks a lot for pointing this out! Post the above PR, a sample run is shown below:
|
Co-authored-by: Sourab Mangrulkar <13534540+pacman100@users.noreply.github.com>
@pacman100, please feel free to merge when you feel it's ready. Thanks. |
I'm not sure why
PYTHONPATH
is set to python executable here as it expects dirs and not files:https://github.com/huggingface/accelerate/pull/514/files#r987305929
but regardless accelerate shouldn't hijack
PYTHONPATH
This PR extends the
PYTHONPATH
instead if it was preset.Thank you