Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update accelerator.py preventing FutureWarning when using GradScaler with cuda #3137

Conversation

jmribeiro
Copy link

What does this PR do?

This small edit prevents the FutureWarning: torch.cuda.amp.GradScaler(args...) is deprecated. Please use torch.amp.GradScaler('cuda', args...) instead.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@muellerzr @BenjaminBossan @SunMarc, this should just be a simple edit, but let me know if anything else is needed.

…and cuda

Update accelerator.py preventing FutureWarning when using GradScaler and cuda:

FutureWarning: `torch.cuda.amp.GradScaler(args...)` is deprecated. Please use `torch.amp.GradScaler('cuda', args...)` instead.
@BenjaminBossan
Copy link
Member

Thanks for the PR, but it's a duplicate of #3132, right? If so, feel free to close the PR.

@jmribeiro
Copy link
Author

Thanks for the PR, but it's a duplicate of #3132, right? If so, feel free to close the PR.

That's correct! Closing.

@jmribeiro jmribeiro closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants