Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make env variables optional for FSDP #2998

Merged
merged 10 commits into from
Aug 12, 2024
Merged

Make env variables optional for FSDP #2998

merged 10 commits into from
Aug 12, 2024

Commits on Aug 7, 2024

  1. Bookmark

    @muellerzr
    muellerzr committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    d5fd90f View commit details
    Browse the repository at this point in the history

  2. Tests pass!

    @muellerzr
    muellerzr committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    b95ad44 View commit details
    Browse the repository at this point in the history

  3. Fix imports

    @muellerzr
    muellerzr committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    c971a7f View commit details
    Browse the repository at this point in the history

  4. Try with raw dict

    @muellerzr
    muellerzr committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    78411d0 View commit details
    Browse the repository at this point in the history

  5. Make diff easier

    @muellerzr
    muellerzr committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    bb21bdc View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Add defaults to all relevent areas

    @muellerzr
    muellerzr committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    f9fd938 View commit details
    Browse the repository at this point in the history

  2. Rest of refactor

    @muellerzr
    muellerzr committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    f83bc90 View commit details
    Browse the repository at this point in the history

  3. Fix all of benjamin's nits

    @muellerzr
    muellerzr committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    f6de455 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Adjust logic based on Benjamin's feedback

    @muellerzr
    muellerzr committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    f4ce667 View commit details
    Browse the repository at this point in the history

  2. Adjust for new logic

    @muellerzr
    muellerzr committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    f8c496c View commit details
    Browse the repository at this point in the history