delete CCL env var setting #2927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@muellerzr @faaany pls help to review. Thanks! |
|
yes, I can verify that multi-card fine-tuning works without these CCL environment variables using the latest torch-ccl&ipex. They were added at a time when users had to handle them manually. But now we can remove them. Pls have a review, thx! @muellerzr |
muellerzr
approved these changes
Jul 15, 2024
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Can you run |
|
@muellerzr Thanks. Format fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deletes some CCL environment variable setting. With versions updating of software stack, current torch-CCL don't recommend manually setting these CCL env vars like 'CCL_LOCAL_SIZE', 'CCL_LOCAL_RANK' or 'CCL_PROCESS_LAUNCHER'.
And
os.environ.get("LOCAL_WORLD_SIZE", "1") os.environ.get("LOCAL_RANK", "0")may not get the correct value. For example, when run fine-tuning with deepspeed on multiple gpus, it will get wrong value and pass them to torchCCL comm backend, which will result in crash.