Fix get_backend bug and add clear_device_cache function #2857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
| @@ -64,7 +64,7 @@ def get_backend(): | |||
| elif is_cuda_available(): | |||
| return "cuda", torch.cuda.device_count(), torch.cuda.memory_allocated | |||
| elif is_mps_available(min_version="2.0"): | |||
| return "mps", 1, torch.mps.current_allocated_memory() | |||
| return "mps", 1, torch.mps.current_allocated_memory | |||
There was a problem hiding this comment.
Nice catch. But doesn't this mean that the return values below "mps", 1, 0 (for old mps) and "cpu", 1, 0 (for CPU) are also broken? Should they return lambda: 0 instead?
There was a problem hiding this comment.
Agreed, we should use a lambda for those
There was a problem hiding this comment.
Yes, you're right. Added lambda: 0. Thanks for pointing that out!
muellerzr
approved these changes
Jul 3, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces 2 updates:
clear_device_cachefunction in memory.py to replace repetitive code. This also adds check for mps devices in functionfind_executable_batch_size. This feature was tested with tests/test_memory_utils.py, which had bug.get_backendfunction where function's 3rd outputs must be callable object. This bug caused failures in tests/test_memory_utils.py on MacOS.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.