Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] project_dir parameter update #1702

Merged
merged 1 commit into from
Jul 11, 2023
Merged

[docs] project_dir parameter update #1702

merged 1 commit into from
Jul 11, 2023

Conversation

stevhliu
Copy link
Member

Updates the Tracking doc to use project_dir instead of the deprecated logging_dir parameter as mentioned here. Let me know if I've interpreted this correctly! 🤗

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 10, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

pacman100
pacman100 approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @stevhliu for updating the docs, LGTM!

@patrickvonplaten
Copy link
Contributor

Nice

sgugger
sgugger approved these changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! @muellerzr can you double check?

muellerzr
muellerzr approved these changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the important update!

@muellerzr muellerzr merged commit d58aac2 into main Jul 11, 2023
4 checks passed
@muellerzr muellerzr deleted the project-dir-config branch July 11, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muellerzr muellerzr muellerzr approved these changes

@pacman100 pacman100 pacman100 approved these changes

@sgugger sgugger sgugger approved these changes

@pcuenca pcuenca Awaiting requested review from pcuenca

@patrickvonplaten patrickvonplaten Awaiting requested review from patrickvonplaten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@stevhliu @HuggingFaceDocBuilderDev @patrickvonplaten @muellerzr @pacman100 @sgugger