Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nightly tests #1696

Merged
merged 3 commits into from
Jul 11, 2023
Merged

Fix nightly tests #1696

merged 3 commits into from
Jul 11, 2023

Conversation

muellerzr
Copy link
Collaborator

Solves the issue of the failing nightly by checking for the right dictionary to be parsed, and ignoring other outputs (the cause of the issue)

@muellerzr muellerzr requested a review from pacman100 July 10, 2023 12:21
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 10, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

pacman100
pacman100 approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @muellerzr for fixing the tests, LGTM!

@muellerzr muellerzr merged commit d0a7991 into main Jul 11, 2023
26 checks passed
@muellerzr muellerzr deleted the fix-nightly branch July 11, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacman100 pacman100 pacman100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muellerzr @HuggingFaceDocBuilderDev @pacman100