Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let quality yell at the user if it's a version difference #1438

Merged
merged 2 commits into from
May 16, 2023

Conversation

muellerzr
Copy link
Collaborator

@muellerzr muellerzr commented May 16, 2023

black let's you do a --required-version, which let's us pin it at 23 (there was no 23.0, only 23.1 so that's fine with our minimals). This lets the user have a much clearer error if something happened locally when we request they do make quality:

Oh no! 💥 💔 💥 The required version `22.1` does not match the running version `23.3.0`!

@muellerzr muellerzr requested a review from sgugger May 16, 2023 12:35
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 16, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it this way, thanks!

@muellerzr muellerzr merged commit a28491b into main May 16, 2023
@muellerzr muellerzr deleted the improve-quality-check branch May 16, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants