fix: typing issues, and replace deprecated python typing (Optional, Union) to |
#1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
|
I can undo the documentation changes if that's more desired |
sgugger
approved these changes
Apr 27, 2023
muellerzr
approved these changes
Apr 27, 2023
|
Thanks for reviewing! So, I should still remove the changes in the doc right? |
|
No those changes are good. It's an oversight on our side. You can just mark your PR as ready and we'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typing issue in #1359 partially. For now, it only changes one file, but we'll need to gradually change all files to follow the new format.