Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to nccl #1314

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Default to nccl #1314

merged 1 commit into from
Apr 14, 2023

Conversation

muellerzr
Copy link
Collaborator

Defaults the kwargs to nccl, as the kwarg handler will sometimes not be used and we still need to use nccl as the default

@muellerzr muellerzr requested a review from sgugger April 14, 2023 13:58
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 14, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger approved these changes Apr 14, 2023
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@muellerzr muellerzr merged commit 40980e8 into main Apr 14, 2023
@muellerzr muellerzr deleted the default branch April 14, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muellerzr @HuggingFaceDocBuilderDev @sgugger