Handle multiple tied parameters #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
muellerzr
approved these changes
Mar 24, 2023
LysandreJik
approved these changes
Mar 24, 2023
| current_memory_used = 0 | ||
| else: | ||
| # Otherwise, we replace the tied module by its children. | ||
| elif len(tied_params) > 0: |
Co-authored-by: Lysandre Debut <lysandre.debut@reseau.eseo.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the internal of big model inference to handle multiple tied parameters (instead of just a pair). It contains a breaking change in the util function
find_tied_parameters(which is used once in Transformers, so we will need an update there). This is because its results as a dictionary doesn't really make sense when we can have groups of three/four tied parameters all together.The logic in
infer_auto_device_mapis getting a lot more complicated, so I added averboseargument to leave plenty of print statements and help future me or others debug what's happening. Tests and integration tests are added as well.