Hardware Auto-Setup Example/Tutorial for Distributed Launch #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add multi gpu launch script add auto setup hardware docs remove an example tiny fixes
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
reviewed
Mar 23, 2023
There was a problem hiding this comment.
Thanks a lot for your PR. I'll echo the comment I made on the Transformers PR: while we're super happy to showcase RunHouse examples, I feel having one page in the doc is maybe a step too far at this stage. Could we focus first on:
- having one example as you did
- say a bit more clearly in the README that RunHouse is one way to run the examples remotely (and there might be others)
- make launch_auto_hardware.mdx a notebook you host on your side and link to it from the examples/README.md
carolineechen
force-pushed
the
hardware-autosetup
branch
from
13efe64 to
4e374e2
Compare
|
Hi @sgugger, thanks for the feedback! I've updated this PR to reflect the comments, let me know if there's anything else |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously discussed with @sgugger and @LysandreJik (cc @dongreenberg), to add example with hardware auto-setup and remote hardware distributed launching for accelerate.
These examples allow users to run accelerate code, tutorials, and scripts on self hosted hardware, including installation of dependencies/environment setup, and optionally, on-demand allocation for cloud instances. This enables reproducibility across any hardware used.
[see also huggingface/transformers/pull/22319 for more context; parallel PR for transformers]
This PR adds
Let me know of any feedback, happy to iterate on this!