Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix lr scheduler issue #1140

Merged
merged 2 commits into from
Mar 2, 2023
Merged

fix lr scheduler issue #1140

merged 2 commits into from
Mar 2, 2023

Conversation

pacman100
Copy link
Contributor

@pacman100 pacman100 marked this pull request as ready for review March 2, 2023 11:52
@pacman100 pacman100 requested review from sgugger and muellerzr March 2, 2023 11:52
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 2, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger approved these changes Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

src/accelerate/accelerator.py Outdated Show resolved Hide resolved
@pacman100 @sgugger
Update src/accelerate/accelerator.py
6d859e9 
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
muellerzr
muellerzr approved these changes Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pacman100 pacman100 merged commit 96ffd34 into huggingface:main Mar 2, 2023
@pacman100 pacman100 deleted the smangrul/fix-lr-scheduler-issue branch March 3, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

@muellerzr muellerzr muellerzr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lr schedulers aren't prepared when using 2.0 nightlies
4 participants
@pacman100 @HuggingFaceDocBuilderDev @muellerzr @sgugger