Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move dynamo.optimize to the end of model preparation #1128

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Move dynamo.optimize to the end of model preparation #1128

merged 1 commit into from
Feb 28, 2023

Conversation

ymwangg
Copy link
Contributor

@ymwangg ymwangg commented Feb 28, 2023

Dynamo no longer supports adding amp wrapper after calling compile/optimize as described in pytorch/pytorch#95641.

@muellerzr
Copy link
Collaborator

CC @sgugger

sgugger
sgugger approved these changes Feb 28, 2023
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks for the fix! (We also need to move this to torch.compile somewhat soon-ish!)

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Feb 28, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@sgugger sgugger merged commit 639c1da into huggingface:main Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ymwangg @muellerzr @HuggingFaceDocBuilderDev @sgugger