Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag use_fp16 for deprecation in 1.0 #1061

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Flag use_fp16 for deprecation in 1.0 #1061

merged 2 commits into from
Feb 13, 2023

Conversation

muellerzr
Copy link
Collaborator

As discussed in https://huggingface.slack.com/archives/C01Q6JPP6NA/p1676299264125009, flags use_fp16 for deprecation once v1.0.0 of Accelerate is released.

@muellerzr muellerzr added the enhancement New feature or request label Feb 13, 2023
@muellerzr muellerzr requested a review from sgugger February 13, 2023 15:04
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Feb 13, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger approved these changes Feb 13, 2023
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@muellerzr muellerzr merged commit 69e4c3c into main Feb 13, 2023
@muellerzr muellerzr deleted the deprecate-use_fp16 branch February 13, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muellerzr @HuggingFaceDocBuilderDev @sgugger