Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve deepspeed notes #1003

Merged
merged 2 commits into from
Jan 24, 2023
Merged

improve deepspeed notes #1003

merged 2 commits into from
Jan 24, 2023

Conversation

stas00
Copy link
Contributor

@stas00 stas00 commented Jan 24, 2023

This PR

  • improves the explanation of what happens during engine.step (deepspeed)
  • fixes some typos

@stas00 stas00 requested a review from pacman100 January 24, 2023 01:20
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jan 24, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

pacman100
pacman100 approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fixes, LGTM! 😄

@stas00 stas00 merged commit c3ea690 into main Jan 24, 2023
@stas00 stas00 deleted the deepspeed-comments branch January 24, 2023 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacman100 pacman100 pacman100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stas00 @HuggingFaceDocBuilderDev @pacman100