Downgrade missing metadata file when checking model output submission…

… to check failure and remove early return. Resolves #138
hubverse-org · Oct 30, 2024 · 8c2d46d · 8c2d46d
1 parent 5c83952
commit 8c2d46d
Show file tree

Hide file tree

Showing 5 changed files with 711 additions and 171 deletions.
diff --git a/R/check_submission_metadata_file_exists.R b/R/check_submission_metadata_file_exists.R
@@ -38,6 +38,6 @@ check_submission_metadata_file_exists <- function(file_path, hub_path = ".") {
     msg_subject = "Metadata file",
     msg_attribute = msg_attribute,
     msg_verbs = c("exists", "does not exist"),
-    error = TRUE
+    error = FALSE
   )
 }
diff --git a/R/validate_model_file.R b/R/validate_model_file.R
@@ -91,9 +91,6 @@ validate_model_file <- function(hub_path, file_path,
       file_path = file_path
     ), file_path
   )
-  if (is_any_error(checks$metadata_exists)) {
-    return(checks)
-  }
 
   custom_checks <- execute_custom_checks(validations_cfg_path = validations_cfg_path)
   checks <- combine(checks, custom_checks)

diff --git a/tests/testthat/_snaps/check_submission_metadata_file_exists.md b/tests/testthat/_snaps/check_submission_metadata_file_exists.md
@@ -12,7 +12,7 @@
     Code
       check_submission_metadata_file_exists(hub_path = hub_path, file_path = "random-model/2022-10-01-random-model.csv")
     Output
-      <error/check_error>
+      <error/check_failure>
       Error:
       ! Metadata file does not exist at path 'model-metadata/random-model.yml' or 'model-metadata/random-model.yaml'.