Defunct expand_model_out_val_grid and create_model_out_submit_tmpl and move to hubValidations #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k and move to hubValidations.
annakrystalli
changed the title
nickreich
reviewed
Jul 8, 2024
nickreich
reviewed
Jul 8, 2024
nickreich
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following breaking change:
expand_model_out_val_grid()andcreate_model_out_submit_tmpl()are now defunt. These functions have been moved tohubValidationsand replaced byhubValidations::expand_model_out_grid()andhubValidations::submission_tmpl(), respectively. The old functions will now error if called with a message that they have moved tohubValidationsand will be removed in a future release.hubValidationsis a much more natural place for these functions asexpand_model_out_val_grid()is exclusively used internally byhubValidationcheck functions whilecreate_model_out_submit_tmplseems to also fit better as a helper for creating template files that can then becompleted by teams ams validated locally before submission. HencehubValidationsfeels like the appropriate home for this function too.This PR and is related to the associated PR in
hubValidationshubverse-org/hubValidations#95