cli: use async await insted of then in deploy #2885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iru89
force-pushed
the
botonic-cli/refactor-to-use-async-await-in-deploy
branch
from
c5f1881
to
a29425a
Compare
Iru89
force-pushed
the
botonic-cli/refactor-to-use-async-await-in-deploy
branch
from
a29425a
to
9a234c5
Compare
vanbasten17
approved these changes
Aug 21, 2024
| const choices = [ | ||
| 'No, I need to create a new one (Signup)', | ||
| 'Yes, I do. (Login)', | ||
| ] | ||
| return prompt([ | ||
| const inp = await prompt([ |
There was a problem hiding this comment.
const {signupConfirmation} = await ...
| else return this.askSignup() | ||
| }) | ||
| ]) | ||
| if (inp.signupConfirmation == choices[1]) return this.askLogin() |
## Description Use new endpoints /v2/bots/ to deploy. Send the bot_config as parameters in the POST call /v2/bots/ instead of adding the json in the separate folder next to the bot zip of the bot to be deployed.
Iru89
merged commit 5e64f32
into
BLT-1008-create-json-with-config-file-on-botonic-deploy
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor the deploy file to always use async await instead of chaining asyncorn functions with callbacks inside the then function.
Context
Approach taken / Explain the design
To document / Usage example
Testing
The pull request...