Added Withdraw form #29
Conversation
|
Thanks @mghazanfar89 |
|
Actual vs Design |
|
Similar issues as https://github.com/hubiinetwork/omphalos-ui/pull/31 |
| return ( | ||
| <Wrapper> | ||
| <Flex> | ||
| <FlexForm onSubmit={this.handleSubmit}> |
There was a problem hiding this comment.
There should be a single form for all the inputs and dropdowns of component rather than multiple forms
| /** | ||
| * gas price in dollar for the component . | ||
| */ | ||
| gasDollar: PropTypes.number.isRequired, |
| title="Available Balance" | ||
| info | ||
| balance={availableBalance} | ||
| showCoinName={availableBalanceCoin} |
There was a problem hiding this comment.
I think balanceCoin and availableBalanceCoin will be same.
There was a problem hiding this comment.
I think the same but I guess that there may exist some scenario where both are different. Hence keeping both of the props.
| /** | ||
| * heading of the component . | ||
| */ | ||
| heading: PropTypes.string.isRequired, |
| }); | ||
| } | ||
|
|
||
| handleAccount(value) { |
There was a problem hiding this comment.
Regarding this, it's a good suggestion, I used to think ES6 classes should be used too. However FB recommends they are defined as methods, see facebook/react#9851
Please let's follow this convention where we can, thanks guys!
| constructor(props) { | ||
| super(props); | ||
| this.state = { | ||
| amount: 1, |
There was a problem hiding this comment.
this should be from props e.g amount:props.amount || 1
No description provided.