Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fgs/function): add new resource for function topping #6226

Merged

Conversation

Lance52259
Copy link
Contributor

@Lance52259 Lance52259 commented Jan 20, 2025

What this PR does / why we need it:
Add a new resource to top the function, there is no limit for function topping currently.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. add new resource for function topping

PR Checklist

  • Tests added/passed.
./scripts/coverage.sh -o fgs -f TestAccFunctionTopping_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/fgs" -v -coverprofile="./huaweicloud/services/acceptance/fgs/fgs_coverage.cov" -coverpkg="./huaweicloud/services/fgs" -run TestAccFunctionTopping_basic -timeout 360m -parallel 10
=== RUN   TestAccFunctionTopping_basic
=== PAUSE TestAccFunctionTopping_basic
=== CONT  TestAccFunctionTopping_basic
--- PASS: TestAccFunctionTopping_basic (15.28s)
PASS
coverage: 12.8% of statements in ./huaweicloud/services/fgs
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/fgs       15.328s coverage: 12.8% of statements in ./huaweicloud/services/fgs
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      image

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2025
@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @Lance52259

@Lance52259 Lance52259 force-pushed the br_fgs_function_topping branch from 6967e6e to c8f0994 Compare February 10, 2025 08:03
@deer-hang
Copy link
Contributor

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Feb 10, 2025
@github-ci-robot github-ci-robot merged commit ba9b60e into huaweicloud:master Feb 10, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants