Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(identitycenter): support permission set tags #6099

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

luoping-12345
Copy link
Contributor

@luoping-12345 luoping-12345 commented Dec 26, 2024

What this PR does / why we need it:
support permission set tags

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

support permission set tags

PR Checklist

  • Tests added/passed.
make testacc TEST='./huaweicloud/services/acceptance/identitycenter' TESTARGS='-run TestAccPermissionSet_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/identitycenter -v -run TestAccPermissionSet_basic -timeout 360m -parallel 4
=== RUN   TestAccPermissionSet_basic
=== PAUSE TestAccPermissionSet_basic
=== CONT  TestAccPermissionSet_basic
--- PASS: TestAccPermissionSet_basic(54.03s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/identitycenter 71.547s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@Alice1319
Copy link

LGTM

1 similar comment
@WangLiNaruto
Copy link

LGTM

@houpeng80
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Dec 27, 2024
@Jason-Zhang9309
Copy link
Collaborator

/approve

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 27, 2024
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Jason-Zhang9309

/approve

@github-ci-robot github-ci-robot merged commit 1542c67 into huaweicloud:master Dec 27, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants