New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix server-set types #16

Merged

htunnicliff merged 4 commits into main from fix-server-types

Dec 1, 2024

Owner

htunnicliff commented Dec 1, 2024 •

edited

Loading

Changes

Adjust nullable values to use optional field modifiers instead.
Annotate immutable and server-set fields with JSDoc comments.
Update */set arguments to omit server-set fields.
Widen Email/set arguments to make all fields optional (RFC8621 § 4.6 is a little unclear here and I want to revisit this soon).
Fix missing PushSubscription type import.

Fixes #15.

htunnicliff added 4 commits

November 29, 2024 12:37


          Ensure optional fields use optional modifier and not null

7cc1e3b


          Omit server-set fields from set arguments

21d13fd


          Adjust additional nullable fields

5fe2591


          Format

69de20b

htunnicliff self-assigned this

htunnicliff merged commit 014c392 into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet