Skip to content

Commit

Permalink
Try removing build-base from CI to simplify if possible
Browse files Browse the repository at this point in the history
Seems like the scripts we're based on for ACT are no longer maintained
and Chrome's automateable download flow has changed quite a bit, so
things are starting to break. Can we get away without it?
  • Loading branch information
pimterry committed Feb 8, 2024
1 parent 88d3163 commit 8fa58b8
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ jobs:
build:
name: Build & test
runs-on: ubuntu-latest
container: httptoolkit/act-build-base:v3.0.0
steps:
- uses: actions/checkout@v3

Expand Down Expand Up @@ -50,7 +49,6 @@ jobs:
name: Check for new blog posts to announce
if: github.event_name == 'push'
runs-on: ubuntu-latest
container: httptoolkit/act-build-base:v3.0.0
needs: build
outputs:
new-blog-post: ${{ steps.detect-changes.outputs.new-blog-post }}
Expand Down Expand Up @@ -98,7 +96,6 @@ jobs:
name: Build & publish container to Docker Hub
if: github.event_name == 'push' && !startsWith(github.ref, 'refs/heads/dependabot/')
runs-on: ubuntu-latest
container: httptoolkit/act-build-base
needs: build
steps:
- uses: actions/checkout@v3
Expand Down Expand Up @@ -138,7 +135,6 @@ jobs:
name: Deploy to Scaleway
if: github.event_name == 'push' && github.ref == 'refs/heads/main'
runs-on: ubuntu-latest
container: httptoolkit/act-build-base:v3.0.0
needs: publish-docker
steps:
- name: Redeploy container
Expand All @@ -165,7 +161,6 @@ jobs:
name: Announce new blog posts
if: github.event_name == 'push' && github.ref == 'refs/heads/main' && needs.check-blog-changes.outputs.new-blog-post != ''
runs-on: ubuntu-latest
container: httptoolkit/act-build-base:v3.0.0
needs:
- check-blog-changes
- publish-scaleway
Expand Down

0 comments on commit 8fa58b8

Please sign in to comment.