Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement TryFrom<&'a str> for HeaderValue and Method #95

Merged
merged 2 commits into from
Apr 14, 2020
Merged

Implement TryFrom<&'a str> for HeaderValue and Method #95

merged 2 commits into from
Apr 14, 2020

Conversation

LukeMathWalker
Copy link
Contributor

@LukeMathWalker LukeMathWalker commented Apr 12, 2020 •
edited
Loading

It defers to the existing implementations of FromStr.
This provides symmetry with what is done for HeaderName.

@LukeMathWalker LukeMathWalker changed the title Implement TryFrom<&'a str> for HeaderValue Implement TryFrom<&'a str> for HeaderValue and Method Apr 12, 2020
rylev
rylev approved these changes Apr 14, 2020
View reviewed changes
Copy link
Collaborator

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@rylev rylev merged commit d094d34 into http-rs:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rylev rylev rylev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LukeMathWalker @rylev