Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow omitting cookie support, with a new "cookies" feature #306

Merged
merged 1 commit into from
Dec 24, 2020

Conversation

joshtriplett
Copy link
Member

The "cookie" crate introduces a substantial dependency tree. Allow
people to omit that dependency if they don't need it.

The "cookie" crate introduces a substantial dependency tree. Allow
people to omit that dependency if they don't need it.
@joshtriplett
Copy link
Member Author

joshtriplett commented Dec 19, 2020

After this, I'd like to change async-h1 to use default-features = false on http-types, and change tide to only depend on http-types/cookies if its own cookies feature is set.

Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable, thank you!

@yoshuawuyts yoshuawuyts merged commit 9bf39c9 into http-rs:main Dec 24, 2020
@joshtriplett
Copy link
Member Author

@yoshuawuyts Thanks! Would it be possible to get a new http-types upload, to allow tide to make use of this change?

@yoshuawuyts
Copy link
Member

We do monthly releases for all the main http-rs libraries, with the next release of http-types planned for the week of January 10th.

Usually I wouldn't mind doing a patch release if requested, but I'm actually planning to spend the holidays away from the computer. Hopefully that's not too late!

@joshtriplett joshtriplett deleted the optional-cookies branch January 17, 2021 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants