ci improvements #275
Merged
ci improvements #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Fishrock123
commented
Nov 5, 2020
Fishrock123
commented
- run on "main"
- really check everything
- move to non-deprecated --workspace from --all
- reduce unecessary actions-rs usage
- really clippy everything
- docs without deps
- run fmt-clippy-docs on beta
- run on "main" - really check everything - move to non-deprecated --workspace from --all - reduce unecessary actions-rs usage - really clippy everything - docs without deps
yoshuawuyts
reviewed
Nov 6, 2020
.github/workflows/ci.yaml
Outdated
Comment on lines
58
to
59
| rustup toolchain install beta | ||
| rustup default beta |
There was a problem hiding this comment.
Can you say more why using beta makes sense here?
There was a problem hiding this comment.
Oh I guess it's just to get us off nightly?
There was a problem hiding this comment.
Yeah, nightly is currently missing rustfmt...
yoshuawuyts
approved these changes
Nov 6, 2020
Fishrock123
force-pushed
the
ci-improvements
branch
from
e8e20d7 to
c4e45fe
Compare
|
Hmm, right we'd need to actually install clippy and rustfmt for beta. How about we just use stable? it's preinstalled on the github actions images and so it would be much faster. But maybe we want to be ahead of the game with beta? Not 100% sure. @yoshuawuyts What do you think? |
Avoids components sometimes not being available on nightly, and has less complexity than running beta.
Fishrock123
force-pushed
the
ci-improvements
branch
from
c4e45fe to
932a676
Compare
|
Ok, this works now, and has less complexity to just run fmt-clippy-docs on stable, as discussed in zulip. Merging this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.