Introduce method shorthands for Request constructor #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 26, 2020 09:45
Expose easy shorthands for Request constructors to match the approach used in Surf. Refs: #156
Fishrock123
reviewed
May 26, 2020
yoshuawuyts
approved these changes
May 26, 2020
There was a problem hiding this comment.
I like this a lot! Seems like cargo fmt may be missing still but otherwise this LGTM.
cc/ @jbr if you'd like to take a look?
|
Fwiw seems fine to me. |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose easy shorthands for Request constructors to match the approach
used in Surf.
Checklist
Refs: #156