This repository has been archived by the owner on Jun 21, 2020. It is now read-only.
Set request peer and local addrs on Response and Request in http-service-h1 #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this happens _after_ the service responds, because the response is built inside of user code
|
Set as a draft because CI is going to break until http-rs/http-types#119 is merged |
in order to accommodate future filesystem sockets
in http-service, specifically
jbr
force-pushed
the
local_and_peer_addrs
branch
from
b85a732 to
898d7b1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set TcpStream peer and local addrs on Requests and Responses. Indirectly addresses http-rs/async-h1#99
Depends on http-rs/http-types#119edit: Now that http-rs/http-types#119 is merged, this depends on http-rs/async-h1#105 or something like that so that it can build against master of http-types to incorporate http-rs/http-types#119.