-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle 'upgrade' in comma-separated connection header #691
Conversation
closes #690 |
This is better fixed with a regular expression. |
Firefox sends `keep-alive, upgrade`, not just `upgrade`, which the proxy incorrectly turned into `close`
2d28cc6
to
871b06f
Compare
Thanks, uses a regular expression now. |
@minrk only problem I have here is that we will probably leak a socket with In regards to the regex, I think you might want |
in websocket connections
871b06f
to
ec683b9
Compare
Uses |
@minrk excellent, thank you! |
handle 'upgrade' in comma-separated connection header
Worth noting that the regular expression instance need not be constructed every time. It's a small perf optimization so I'm not sure how meaningful it would be. |
Firefox sends
keep-alive, upgrade
, not justupgrade
, which was being turned intoclose
.