-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better examples #520
Better examples #520
Conversation
Ok there is a very weird trouble in TypeError: Cannot set property 'XHR' of undefined The last part of the stack trace show this:
|
Ready for review and merge cc: @yawnt @indexzero |
@cronopio looks good but i the travis CI build is failing, if you fix that we can merge :) |
@yawnt Thank you. Seems that there is a trouble running the coveralls script. Can I drop it from the |
Actually I think there is the same trouble in |
damn,sucks.. okay drop it T_T |
Oh. Seems that this commit 9e74a63 break the tests. I'll investigate and fix it before the merge. I'll let you know when is ready to merge |
okay, but i don't think it's related.. it's such an insignificant addition to the codebase :\ |
* I changed all the ports across examples to be different and can run at same time
Ok, I fixed the stuff and rebase it. Now travis is failing due another stuff. This is ready to merge |
For what it's worth, I have gotten caronte to work for my use case. See https://gist.github.com/risacher/8302220 |
@risacher Oh thanks! that is helpful, I'll take a deep look in a few hours, maybe you can format it like the examples I made and then open a pull request 😉 |
I just rewrite the examples, just using as base the old examples, so I updated all this examples according to the new improvements and the new api of node-http-proxy.
Review and merge
CC: @yawnt