Enable proxy response to have multiple Set-Cookie raw headers #1101 #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcrugzz
reviewed
Dec 4, 2016
| @@ -99,18 +106,21 @@ module.exports = { // <-- | |||
|
|
|||
| // message.rawHeaders is added in: v0.11.6 | |||
| // https://nodejs.org/api/http.html#http_message_rawheaders | |||
| if (proxyRes.rawHeaders != undefined) { | |||
| if (proxyRes.rawHeaders !== undefined) { | |||
There was a problem hiding this comment.
The current code here supports if it is undefined or null, we should be sure that it is strictly undefined.
| @@ -84,12 +84,19 @@ module.exports = { // <-- | |||
| */ | |||
| writeHeaders: function writeHeaders(req, res, proxyRes, options) { | |||
| var rewriteCookieDomainConfig = options.cookieDomainRewrite, | |||
| // In proxyRes.rawHeaders Set-Cookie headers are sparse. | |||
| // so, we'll collect Set-Cookie headers, and set them in the response as an array. | |||
| set_cookies = [], | |||
| setHeader = function(key, header) { | ||
| if (header != undefined) { | ||
| if (rewriteCookieDomainConfig && key.toLowerCase() === 'set-cookie') { | ||
| header = common.rewriteCookieDomain(header, rewriteCookieDomainConfig); | ||
| if (key === 'Set-Cookie' || key === 'set-cookie') { |
There was a problem hiding this comment.
we can still do key.toLowerCase() === 'set-cookie'
|
cherry-picked, thanks! |
|
@kriswill Thanks to fix this issue. and sorry for any inconvenience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of proxy HTTP raw headers response processing in 1.16.0 fails to account for multiple
Set-Cookieheaders. This patch accounts for multiple Set-Cookie header, and sets the source response headers to an array.