Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Response field key should use raw key name #1029

Closed
fundon opened this issue Jun 26, 2016 · 4 comments
Closed

Response field key should use raw key name #1029

fundon opened this issue Jun 26, 2016 · 4 comments

Comments

@fundon
Copy link

fundon commented Jun 26, 2016 •
edited
Loading

See https://github.com/nodejitsu/node-http-proxy/blob/master/lib/http-proxy/passes/web-outgoing.js#L83-L89.

The proxyRes.headers are in lowercase. But the raw headers is not.
So I thought that we should use proxyRes.rawHeaders instead of proxyRes.headers.
@fundon fundon changed the title Response filed key should use raw key name Response field key should use raw key name Jun 27, 2016
@fragsalat
Copy link

👍

1 similar comment
@oleynikd
Copy link

👍

pachirel added a commit to pachirel/node-http-proxy that referenced this issue Dec 1, 2016
@pachirel
Keep character case of response header keys
bc0ad02 
http-party#1029
@pachirel pachirel mentioned this issue Dec 1, 2016
Merged
@jcrugzz
Copy link
Contributor

jcrugzz commented Dec 2, 2016

Fixed in 1.16.0

@jcrugzz jcrugzz closed this as completed Dec 2, 2016
@pachirel
Copy link
Contributor

pachirel commented Dec 7, 2016

I added preserveHeaderKeyCase option. If the option is enabled, you can get raw key name. #1104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@fundon @pachirel @jcrugzz @fragsalat @oleynikd