-
Notifications
You must be signed in to change notification settings - Fork 2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[fix] Partial fix for rejecting self-signed certs in tests
Since nodejs/node-v0.x-archive@35607f3, https and tls modules validate server certificate by default. Turn this feature off since we're using self-signed certificates in tests. Currently wss tests are still failing, pending investigation. Commited on a plane from Poznań to Munich.
- Loading branch information
Showing
3 changed files
with
5 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2e7d8a8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the option
rejectUnauthorized
fully supported by the proxy? I cannot find it's reference in the*.js
files inside thelib
folder.2e7d8a8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It became supported since eafdc74.
Agent
acceptsrejectUnauthorized
.2e7d8a8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. It will be deployed in
v0.8.4
, right?2e7d8a8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. I'll release v0.8.4 once I fix all test failures on node v0.9.