Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option for custom headers #885

Closed
wants to merge 2 commits into from

Conversation

kipcode66
Copy link

@kipcode66 kipcode66 commented Aug 10, 2024

This PR adds an option to provide custom headers.

Relevant issues

Resolves #884

Contributor checklist
  • Provide tests for the changes (unless documentation-only)
  • Documented any new features, CLI switches, etc. (if applicable)
    • Server --help output
    • README.md
    • doc/http-server.1 (use the same format as other entries)
  • The pull request is being made against the master branch
Maintainer checklist
  • Assign a version triage tag
  • Approve tests if applicable

@kipcode66
Copy link
Author

I was coming back to make tests for this PR and fix the fact it doesn't handle colons in the header values, but I saw there was an other PR #887 which uses the curl approach to adding headers. Which approach would be prefered? should I just close this one if we'd rather use the curl-based one?

@KernelDeimos
Copy link
Contributor

I was coming back to make tests for this PR and fix the fact it doesn't handle colons in the header values, but I saw there was an other PR #887 which uses the curl approach to adding headers. Which approach would be prefered? should I just close this one if we'd rather use the curl-based one?

Thanks for bringing the dupe to my attention. I like the idea of using known conventions where possible. Let's move focus to #887, and I've also opened discussion #899 so we can talk about superset syntax (i.e. maybe we allow semicolon-separated values as well if it doesn't conflict with curl's convention, because that seems more convenient to me).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User-provided custom headers
2 participants