Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #371 carousel plugin in rtl mode #372

Merged
merged 1 commit into from
Jul 22, 2024
Merged

fixes #371 carousel plugin in rtl mode #372

merged 1 commit into from
Jul 22, 2024

Conversation

ZedObaia
Copy link
Contributor

@ZedObaia ZedObaia commented May 20, 2024 •
edited
Loading

Fixes #371

Changes

  • Add isRTL option
  • calculate the transform correctly based on the new flag

@ZedObaia
Copy link
Contributor Author

Hi there.
I created this PR to get the ball rolling, it might not be perfect and I could not find ant docs regarding contributing. I'm happy to help and adjust further if needed, any comments are appreciated

@jahaganiev jahaganiev merged commit 6229181 into htmlstreamofficial:main Jul 22, 2024
@bamanczak bamanczak mentioned this pull request Aug 18, 2024
Merged
@stevenalp207 stevenalp207 mentioned this pull request Sep 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Carousel Plugin Bug: Incorrect Behavior in RTL dir
2 participants
@ZedObaia @jahaganiev