Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced generate-dts script with a config file #232

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

timocov
Copy link
Contributor

@timocov timocov commented Dec 29, 2023

This PR contains 2 changes:

  • using no-banner CLI (or config option in the second commit) option to remove "banner" from output instead of in-house function (if it really annoys)
  • creating a config that combines complication into one step to avoid wasting CI and developer's time (see below)

Compilation is slow, compiling the same project again and again is even slower (on my machine npm run generate-dts on main branch takes around 2 minutes to complete).

dts-bundle-generator provides a way to "combine" a compilation of a project into one step and then generate bundles for each entry point separately. As result, npm run generate-dts now takes around 3-4 seconds:

$ npm run generate-dts

> preline@2.0.3 generate-dts
> dts-bundle-generator --config dts-config.js

Compiling input files...
Processing src/index.ts
Processing src/plugins/accordion/index.ts
Processing src/plugins/carousel/index.ts
Processing src/plugins/collapse/index.ts
Processing src/plugins/copy-markup/index.ts
Processing src/plugins/dropdown/index.ts
Processing src/plugins/input-number/index.ts
Processing src/plugins/overlay/index.ts
Processing src/plugins/pin-input/index.ts
Processing src/plugins/remove-element/index.ts
Processing src/plugins/scrollspy/index.ts
Processing src/plugins/search-by-json/index.ts
Processing src/plugins/select/index.ts
Processing src/plugins/stepper/index.ts
Processing src/plugins/strong-password/index.ts
Processing src/plugins/tabs/index.ts
Processing src/plugins/theme-switch/index.ts
Processing src/plugins/toggle-count/index.ts
Processing src/plugins/toggle-password/index.ts
Processing src/plugins/tooltip/index.ts
Writing src/index.ts -> dist/index.d.ts
Writing src/plugins/accordion/index.ts -> dist/accordion.d.ts
Writing src/plugins/carousel/index.ts -> dist/carousel.d.ts
Writing src/plugins/collapse/index.ts -> dist/collapse.d.ts
Writing src/plugins/copy-markup/index.ts -> dist/copy-markup.d.ts
Writing src/plugins/dropdown/index.ts -> dist/dropdown.d.ts
Writing src/plugins/input-number/index.ts -> dist/input-number.d.ts
Writing src/plugins/overlay/index.ts -> dist/overlay.d.ts
Writing src/plugins/pin-input/index.ts -> dist/pin-input.d.ts
Writing src/plugins/remove-element/index.ts -> dist/remove-element.d.ts
Writing src/plugins/scrollspy/index.ts -> dist/scrollspy.d.ts
Writing src/plugins/search-by-json/index.ts -> dist/search-by-json.d.ts
Writing src/plugins/select/index.ts -> dist/select.d.ts
Writing src/plugins/stepper/index.ts -> dist/stepper.d.ts
Writing src/plugins/strong-password/index.ts -> dist/strong-password.d.ts
Writing src/plugins/tabs/index.ts -> dist/tabs.d.ts
Writing src/plugins/theme-switch/index.ts -> dist/theme-switch.d.ts
Writing src/plugins/toggle-count/index.ts -> dist/toggle-count.d.ts
Writing src/plugins/toggle-password/index.ts -> dist/toggle-password.d.ts
Writing src/plugins/tooltip/index.ts -> dist/tooltip.d.ts
Checking generated files...
Done in 3.54s

@timocov timocov changed the title Replace in-house function to remove banner with CLI argument Replaced generate-dts script with a config file Dec 29, 2023
@timocov timocov marked this pull request as ready for review December 29, 2023 12:07
@jahaganiev
Copy link
Member

Thanks for the input!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants