Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(attr-lowercase): ignore camelCase SVG attributes #828

Merged
merged 1 commit into from
Dec 31, 2021

Conversation

nschonni
Copy link
Contributor

Short description of what this resolves:

Sets up the known SVG properties as the baseline to ignore in
Closes #542

Note that maybe this will cause some unintended passing, since it's not restricted to just the SVG elements. Making it more precise might be an alternate approach

@github-actions github-actions bot added core Relates to HTMLHint's core APIs and features test labels Dec 14, 2021
@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #828 (0147b76) into master (8900d14) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #828   +/-   ##
=======================================
  Coverage   96.44%   96.44%           
=======================================
  Files           1        1           
  Lines         900      901    +1     
  Branches      191      191           
=======================================
+ Hits          868      869    +1     
  Misses         13       13           
  Partials       19       19           
Impacted Files Coverage Δ
dist/htmlhint.js 96.44% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8900d14...0147b76. Read the comment docs.

@nschonni nschonni merged commit aa16722 into htmlhint:master Dec 31, 2021
@nschonni nschonni deleted the svg-attr-lowercase branch December 31, 2021 17:01
@thedaviddias
Copy link
Member

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Relates to HTMLHint's core APIs and features released test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

attr-lowercase should ignore camelCase SVG attributes by default
2 participants